<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115710/">https://git.reviewboard.kde.org/r/115710/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On February 27th, 2014, 8:09 p.m. UTC, <b>David Faure</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/115710/diff/3/?file=246152#file246152line123" style="color: black; font-weight: bold; text-decoration: underline;">src/khistorycombobox.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">connect</span><span class="p">(</span><span class="k"><span class="hl">this</span></span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">aboutToShowContextMenu</span><span class="p">(</span><span class="n">QMenu</span><span class="o">*</span><span class="p">)),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">addContextMenuItems</span><span class="p">(</span><span class="n">QMenu</span><span class="o">*</span><span class="p">)));</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">107</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n"><span class="hl">q</span></span><span class="o"><span class="hl">-></span></span><span class="n">connect</span><span class="p">(</span><span class="n"><span class="hl">q</span></span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">aboutToShowContextMenu</span><span class="p">(</span><span class="n">QMenu</span><span class="o">*</span><span class="p">)),</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">addContextMenuItems</span><span class="p">(</span><span class="n">QMenu</span><span class="o">*</span><span class="p">)));</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">q->connect is a strange way to call a static method. QObject::connect would be usual (if a bit more verbose).</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">IMHO, it isn't actually so strange:

Instead of

QObject::connect(sender, SIGNAL, receiver, SLOT);

it becomes

receiver->connect(sender, SIGNAL, SLOT);

http://qt-project.org/doc/qt-5/qobject.html#connect-3

Am I right?</pre>
<br />




<p>- David</p>


<br />
<p>On February 25th, 2014, 10:50 p.m. UTC, David Gil Oliva wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Gil Oliva.</div>


<p style="color: grey;"><i>Updated Feb. 25, 2014, 10:50 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcompletion
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hide private methods and slots behind the d-pointer in KHistoryComboBox

Also:
-Remove header not used</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It builds. Tests pass.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/kcombobox_unittest.cpp <span style="color: grey">(49ef721)</span></li>

 <li>src/khistorycombobox.h <span style="color: grey">(3667eb4)</span></li>

 <li>src/khistorycombobox.cpp <span style="color: grey">(6f81dda)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115710/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>