Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

[Matthieu Gallien]

> On Feb. 26, 2014, 12:07 p.m., Alex Merry wrote:
> > ioslave/CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/116056/diff/1/?file=246123#file246123line9>
> >
> >     I found I needed to link against KF5::I18n; I wonder why you didn't?

The problem is in KIO (/home/mgallien/kde/include/KF5/KIOCore/kio/slavebase.h) and not in kdnssd.
I have a review request to do for kio to fix that.


On Feb. 26, 2014, 12:07 p.m., Matthieu Gallien wrote:
> > Thanks for doing this work, and sorry for not using it!
> > 
> > In terms of what to do instead, I suggest one of:
> > - look into porting things in kde-runtime (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization)
> > - the "reduce mentions of kde 4 in source code" task from http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation#Tasks_for_Final_Release
> > - look for todos and warnings in the frameworks to resolve
> > 
> > If you want more pointers, I and other frameworks folks are usually hanging around on #kde-devel on irc, and there's the kde-frameworks-devel email list.

Do not worry.
I only have very limited free time and cannot make any promises. This is why I avoid talking about things before finishing them.


- Matthieu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116056/#review50915
-----------------------------------------------------------


On Feb. 25, 2014, 9:02 p.m., Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116056/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 9:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdnssd
> 
> 
> Description
> -------
> 
> Basic port to Qt5 and Kf5 in order to help the merge of the two kdnssd repositories.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt df842d4 
>   ioslave/CMakeLists.txt 40c2d67 
>   ioslave/dnssd.h 89afd8d 
>   ioslave/dnssd.cpp c0c8ada 
>   ioslave/zeroconfurl.h f4f06de 
>   kdedmodule/CMakeLists.txt 6232940 
>   kdedmodule/dnssdwatcher.h a2062fc 
>   kdedmodule/dnssdwatcher.cpp 2e4dc25 
>   kdedmodule/watcher.h 5d5470b 
>   kdedmodule/watcher.cpp 21018b9 
> 
> Diff: https://git.reviewboard.kde.org/r/116056/diff/
> 
> 
> Testing
> -------
> 
> Not much. I do not know how to test the ioslave without something like dolphin.
> 
> 
> Thanks,
> 
> Matthieu Gallien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140226/e1d526f0/attachment.html>