<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116056/">https://git.reviewboard.kde.org/r/116056/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 26th, 2014, 12:07 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116056/diff/1/?file=246123#file246123line9" style="color: black; font-weight: bold; text-decoration: underline;">ioslave/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kio_zeroconf</span> <span class="s">KF5::DNSSD</span> <span class="s">KF5::KIOCore</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found I needed to link against KF5::I18n; I wonder why you didn't?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem is in KIO (/home/mgallien/kde/include/KF5/KIOCore/kio/slavebase.h) and not in kdnssd.
I have a review request to do for kio to fix that.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 26th, 2014, 12:07 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for doing this work, and sorry for not using it!
In terms of what to do instead, I suggest one of:
- look into porting things in kde-runtime (see http://community.kde.org/Frameworks/Epics/New_Runtime_Organization)
- the "reduce mentions of kde 4 in source code" task from http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation#Tasks_for_Final_Release
- look for todos and warnings in the frameworks to resolve
If you want more pointers, I and other frameworks folks are usually hanging around on #kde-devel on irc, and there's the kde-frameworks-devel email list.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do not worry.
I only have very limited free time and cannot make any promises. This is why I avoid talking about things before finishing them.</pre>
<br />
<p>- Matthieu</p>
<br />
<p>On February 25th, 2014, 9:02 p.m. CET, Matthieu Gallien wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Matthieu Gallien.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 9:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdnssd
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic port to Qt5 and Kf5 in order to help the merge of the two kdnssd repositories.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not much. I do not know how to test the ioslave without something like dolphin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(df842d4)</span></li>
<li>ioslave/CMakeLists.txt <span style="color: grey">(40c2d67)</span></li>
<li>ioslave/dnssd.h <span style="color: grey">(89afd8d)</span></li>
<li>ioslave/dnssd.cpp <span style="color: grey">(c0c8ada)</span></li>
<li>ioslave/zeroconfurl.h <span style="color: grey">(f4f06de)</span></li>
<li>kdedmodule/CMakeLists.txt <span style="color: grey">(6232940)</span></li>
<li>kdedmodule/dnssdwatcher.h <span style="color: grey">(a2062fc)</span></li>
<li>kdedmodule/dnssdwatcher.cpp <span style="color: grey">(2e4dc25)</span></li>
<li>kdedmodule/watcher.h <span style="color: grey">(5d5470b)</span></li>
<li>kdedmodule/watcher.cpp <span style="color: grey">(21018b9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116056/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>