Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/
-----------------------------------------------------------

(Updated Feb. 25, 2014, 10:50 p.m.)


Review request for KDE Frameworks.


Changes
-------

Add unittest.


Repository: kcompletion


Description
-------

Hide private methods and slots behind the d-pointer in KHistoryComboBox

Also:
-Remove header not used


Diffs (updated)
-----

  autotests/kcombobox_unittest.cpp 49ef721 
  src/khistorycombobox.h 3667eb4 
  src/khistorycombobox.cpp 6f81dda 

Diff: https://git.reviewboard.kde.org/r/115710/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140225/11fcd33b/attachment-0001.html>