Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

David Gil Oliva davidgiloliva at gmail.com
Sun Feb 23 23:23:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/
-----------------------------------------------------------

(Updated Feb. 23, 2014, 11:23 p.m.)


Review request for KDE Frameworks.


Changes
-------

Address David Faure's comments.


Repository: kcompletion


Description
-------

Hide private methods and slots behind the d-pointer in KHistoryComboBox

Also:
-Remove header not used


Diffs (updated)
-----

  src/khistorycombobox.h 3667eb4 
  src/khistorycombobox.cpp 6f81dda 

Diff: https://git.reviewboard.kde.org/r/115710/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140223/82e02266/attachment.html>


More information about the Kde-frameworks-devel mailing list