Review Request 115960: Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().
Matthew John Dawson
matthew at mjdsystems.ca
Tue Feb 25 16:03:08 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115960/#review50833
-----------------------------------------------------------
Ship it!
Ship It!
- Matthew John Dawson
On Feb. 23, 2014, 6:15 a.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115960/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2014, 6:15 a.m.)
>
>
> Review request for KDE Frameworks and Matthew John Dawson.
>
>
> Repository: kconfig
>
>
> Description
> -------
>
> Add sharedConfig() accessor, to avoid manipulating a raw KConfig * as returned by config().
>
> This is useful when using kconfigxt and some other code to read from the same
> config file (e.g. KColorScheme::contrastF(config)) - no need to call KSharedConfig::openConfig
> twice, just grab the KSharedConfig from the generated class.
>
>
> Diffs
> -----
>
> src/core/kcoreconfigskeleton.h 9cd079941fa6f870a19bdbdb945aafe858b4c51a
> src/core/kcoreconfigskeleton.cpp 98d9cdccec3cf3925bb68e2d0cff1b5a1276c56a
>
> Diff: https://git.reviewboard.kde.org/r/115960/diff/
>
>
> Testing
> -------
>
> About to use it in kde-workspace.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140225/3cd925ee/attachment.html>
More information about the Kde-frameworks-devel
mailing list