Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox
David Gil Oliva
davidgiloliva at gmail.com
Sun Feb 23 23:22:08 UTC 2014
> On Feb. 15, 2014, 7:38 p.m., David Faure wrote:
> > src/khistorycombobox.cpp, line 508
> > <https://git.reviewboard.kde.org/r/115710/diff/1/?file=243810#file243810line508>
> >
> > infinite recursion!
> >
> > Sounds like a unittest for reset() should be added.
There are two reset() methods, the private slot and the public method, which only calls the private slot. My error was not calling the d-pointer method:
void KHistoryComboBox::reset()
{
Q_D(KHistoryComboBox);
d->reset();
}
Maybe the private slot could be substituted by the public method (making it a public slot)?
By the way, I would need a hint about the unittest that you think that should be added.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review49866
-----------------------------------------------------------
On Feb. 12, 2014, 11:28 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115710/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 11:28 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcompletion
>
>
> Description
> -------
>
> Hide private methods and slots behind the d-pointer in KHistoryComboBox
>
> Also:
> -Remove header not used
>
>
> Diffs
> -----
>
> src/khistorycombobox.h 3667eb4
> src/khistorycombobox.cpp 6f81dda
>
> Diff: https://git.reviewboard.kde.org/r/115710/diff/
>
>
> Testing
> -------
>
> It builds. Tests pass.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140223/a928f8ee/attachment.html>
More information about the Kde-frameworks-devel
mailing list