Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115710/#review49866
-----------------------------------------------------------



src/khistorycombobox.cpp
<https://git.reviewboard.kde.org/r/115710/#comment35037>

    Shouldn't q->NoInsert be KHistoryComboBox::NoInsert? Just to make sure all compilers are happy.



src/khistorycombobox.cpp
<https://git.reviewboard.kde.org/r/115710/#comment35038>

    infinite recursion!
    
    Sounds like a unittest for reset() should be added.


- David Faure


On Feb. 12, 2014, 11:28 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115710/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 11:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Hide private methods and slots behind the d-pointer in KHistoryComboBox
> 
> Also:
> -Remove header not used
> 
> 
> Diffs
> -----
> 
>   src/khistorycombobox.h 3667eb4 
>   src/khistorycombobox.cpp 6f81dda 
> 
> Diff: https://git.reviewboard.kde.org/r/115710/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/5ea821dd/attachment.html>