Review Request 115875: kconfigtest: write everything into a subdirectory

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115875/#review50580
-----------------------------------------------------------



autotests/kconfigtest.cpp
<https://git.reviewboard.kde.org/r/115875/#comment35571>

    This is a global setting, not toggled on/off, nor does it only apply to the next line. Why not leave it as the first statement of initTestCase()? It would reassure me that everything uses that mode, rather than risking that some other call ends up with the user's dir before testConfigDir() is called.



autotests/kconfigtest.cpp
<https://git.reviewboard.kde.org/r/115875/#comment35572>

    There's a lot of testConfigDir() + "../kdeglobals" in many places. Maybe make an inline method for that, in case we change our mind again about where it should reside?


- David Faure


On Feb. 18, 2014, 9:52 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115875/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 9:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> kconfigtest: write everything into a subdirectory
> 
> This test keeps deleting the whole ~/.qttest directory. By moving all data
> into a subdirectory it is now possible to run multiple tests that use
> kconfig in parallel.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 1c0dc1cf63539e29236ab57e1e848930b468053a 
> 
> Diff: https://git.reviewboard.kde.org/r/115875/diff/
> 
> 
> Testing
> -------
> 
> Test still passes. No files (except kdeglobals) are created in ~/.qttest
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140223/1699883a/attachment.html>