Review Request 115875: kconfigtest: write everything into a subdirectory

Alexander Richardson arichardson.kde at googlemail.com
Fri Feb 21 15:47:00 UTC 2014



> On Feb. 21, 2014, 7:35 a.m., Kevin Ottens wrote:
> > autotests/kconfigtest.cpp, line 219
> > <https://git.reviewboard.kde.org/r/115875/diff/1/?file=244867#file244867line219>
> >
> >     Hm we're loosing the test mode for QStandardPaths, I don't think that's desirable.

It is done inside testConfigDir()


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115875/#review50435
-----------------------------------------------------------


On Feb. 18, 2014, 10:52 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115875/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 10:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> kconfigtest: write everything into a subdirectory
> 
> This test keeps deleting the whole ~/.qttest directory. By moving all data
> into a subdirectory it is now possible to run multiple tests that use
> kconfig in parallel.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 1c0dc1cf63539e29236ab57e1e848930b468053a 
> 
> Diff: https://git.reviewboard.kde.org/r/115875/diff/
> 
> 
> Testing
> -------
> 
> Test still passes. No files (except kdeglobals) are created in ~/.qttest
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140221/39f232be/attachment.html>


More information about the Kde-frameworks-devel mailing list