Review Request 115932: Add declarative plugin for KWindowSystem

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115932/#review50468
-----------------------------------------------------------


the approach looks good to me, just two small requests:
* make it complete (everything Q_INVOKABLE what makes sense (not self or things which cannot be exported))
* provide an example "app" in tests/ - I assume you already have some QML?

- Martin Gräßlin


On Feb. 21, 2014, 1:27 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115932/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2014, 1:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Adds a declarative plugin usable from QML. Usage is as easy as "KWindowSystem.workArea(0)" in QML. So far only the workArea is accessible, not sure which other methods should be. All of them?
> 
> I've made the import version to match the framework version, so you'd do "import org.kde.kwindowsystem 5.0"
> 
> 
> Diffs
> -----
> 
>   declarative/CMakeLists.txt PRE-CREATION 
>   declarative/kwindowsystemplugin.h PRE-CREATION 
>   declarative/kwindowsystemplugin.cpp PRE-CREATION 
>   declarative/qmldir PRE-CREATION 
>   src/kwindowsystem.h e10f7c1 
>   CMakeLists.txt cbae838 
> 
> Diff: https://git.reviewboard.kde.org/r/115932/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140221/c16a36b7/attachment.html>