<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115932/">https://git.reviewboard.kde.org/r/115932/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the approach looks good to me, just two small requests:
* make it complete (everything Q_INVOKABLE what makes sense (not self or things which cannot be exported))
* provide an example "app" in tests/ - I assume you already have some QML?</pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On February 21st, 2014, 1:27 p.m. CET, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Gräßlin.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2014, 1:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a declarative plugin usable from QML. Usage is as easy as "KWindowSystem.workArea(0)" in QML. So far only the workArea is accessible, not sure which other methods should be. All of them?
I've made the import version to match the framework version, so you'd do "import org.kde.kwindowsystem 5.0"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>declarative/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarative/kwindowsystemplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarative/kwindowsystemplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>declarative/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kwindowsystem.h <span style="color: grey">(e10f7c1)</span></li>
<li>CMakeLists.txt <span style="color: grey">(cbae838)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115932/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>