Review Request 115634: Add kconfig_compiler autotest that checks whether signals are emitted

Alexander Richardson arichardson.kde at googlemail.com
Thu Feb 20 15:53:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115634/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 4:53 p.m.)


Review request for KDE Frameworks.


Changes
-------

Simplify the test by testing only QString -> no more ugly macro

Checking all that correct code is generated for all datatypes will be added in separate unit test


Repository: kconfig


Description
-------

Add kconfig_compiler autotest that checks whether signals are emitted

Currently this works when using the setters, however when using
setProperty() on the KCoreConfigSkeleton* (as done by KConfigDialog) no
signals are emitted.


Diffs (updated)
-----

  autotests/kconfig_compiler/signals_test_no_singleton_dpointer.kcfgc PRE-CREATION 
  autotests/kconfig_compiler/signals_test_singleton.kcfgc PRE-CREATION 
  autotests/kconfig_compiler/signals_test_singleton_dpointer.kcfgc PRE-CREATION 
  autotests/kconfig_compiler/CMakeLists.txt a2ebb9453bacb2c7507bc9477b6753a34bbcd434 
  autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp PRE-CREATION 
  autotests/kconfig_compiler/signals_test.kcfg PRE-CREATION 
  autotests/kconfig_compiler/signals_test_no_singleton.kcfgc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115634/diff/


Testing
-------

Compiles, tests fail until https://git.reviewboard.kde.org/r/115635/ is applied, then they pass.

Rather ugly code IMO, open for suggestions to improve it...


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/cc083116/attachment.html>


More information about the Kde-frameworks-devel mailing list