<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115634/">https://git.reviewboard.kde.org/r/115634/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 4:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplify the test by testing only QString -> no more ugly macro
Checking all that correct code is generated for all datatypes will be added in separate unit test</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add kconfig_compiler autotest that checks whether signals are emitted
Currently this works when using the setters, however when using
setProperty() on the KCoreConfigSkeleton* (as done by KConfigDialog) no
signals are emitted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, tests fail until https://git.reviewboard.kde.org/r/115635/ is applied, then they pass.
Rather ugly code IMO, open for suggestions to improve it...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kconfig_compiler/signals_test_no_singleton_dpointer.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/signals_test_singleton.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/signals_test_singleton_dpointer.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(a2ebb9453bacb2c7507bc9477b6753a34bbcd434)</span></li>
<li>autotests/kconfig_compiler/kconfigcompiler_test_signals.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/signals_test.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kconfig_compiler/signals_test_no_singleton.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115634/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>