Review Request 115891: Make KFontDialog inherit from KDialog

Commit Hook null at kde.org
Thu Feb 20 07:07:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115891/#review50304
-----------------------------------------------------------


This review has been submitted with commit 2f26d62ce159d30a1af2e19044e86bb10a1be805 by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 19, 2014, 8:01 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115891/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2014, 8:01 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> Make KFontDialog inherit from KDialog
> 
> Used to be like that in kde4, so we have less SC breakage if we
> inherit from KDialog again.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kfontdialog.h 4bf42010ccfbe61549973d7719d2b950b2aaea27 
>   src/kdeui/kfontdialog.cpp a88207396174444d863207a66902328bd5d00db1 
> 
> Diff: https://git.reviewboard.kde.org/r/115891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/6ba33afb/attachment.html>


More information about the Kde-frameworks-devel mailing list