Review Request 115891: Make KFontDialog inherit from KDialog
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Feb 19 10:09:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115891/#review50198
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Feb. 19, 2014, 8:01 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115891/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:01 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kde4support
>
>
> Description
> -------
>
> Make KFontDialog inherit from KDialog
>
> Used to be like that in kde4, so we have less SC breakage if we
> inherit from KDialog again.
>
>
> Diffs
> -----
>
> src/kdeui/kfontdialog.h 4bf42010ccfbe61549973d7719d2b950b2aaea27
> src/kdeui/kfontdialog.cpp a88207396174444d863207a66902328bd5d00db1
>
> Diff: https://git.reviewboard.kde.org/r/115891/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/1cfc762f/attachment.html>
More information about the Kde-frameworks-devel
mailing list