Review Request 115818: Support more catalogs and reduce code duplication

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115818/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 11:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for Documentation and KDE Frameworks.


Repository: kdoctools


Description
-------

Don't duplicate the code which searches the catalog(s) between xslt.cpp and meinproc.cpp, centralize it in getAllKDocToolsCatalogs.
    
Also, allow the usage of multiple catalogs (catalog.xml is always the main one); this can be useful to allow other modules to drop-in other DTD definitions (for example, if the main DTD is changed to use DocBook XML 4.5 instead of 4.2, the 4.2-based can be defined in a compatibility catalog installed by kde4support).


Diffs
-----

  src/meinproc.cpp 86e83ae 
  src/xslt.h 6fd2dae 
  src/xslt.cpp 70e0d6a 

Diff: https://git.reviewboard.kde.org/r/115818/diff/


Testing
-------


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/99739530/attachment.html>