<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115818/">https://git.reviewboard.kde.org/r/115818/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2014, 11:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't duplicate the code which searches the catalog(s) between xslt.cpp and meinproc.cpp, centralize it in getAllKDocToolsCatalogs.
Also, allow the usage of multiple catalogs (catalog.xml is always the main one); this can be useful to allow other modules to drop-in other DTD definitions (for example, if the main DTD is changed to use DocBook XML 4.5 instead of 4.2, the 4.2-based can be defined in a compatibility catalog installed by kde4support).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/meinproc.cpp <span style="color: grey">(86e83ae)</span></li>
<li>src/xslt.h <span style="color: grey">(6fd2dae)</span></li>
<li>src/xslt.cpp <span style="color: grey">(70e0d6a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115818/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>