Review Request 115744: Fix projects using KDocTools on windows.

Alexander Richardson arichardson.kde at googlemail.com
Wed Feb 19 19:45:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 8:45 p.m.)


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
-------

Fix the real issue: Since I have https://git.reviewboard.kde.org/r/115210/ applied locally the install path contains C:/kf5/install/../../ProgramData/share.
This resulted in a wrong relative path in kdex.dtd at line 100 (8 times ../ instead of 4).


Summary (updated)
-----------------

Fix projects using KDocTools on windows.


Repository: kdoctools


Description (updated)
-------

Fix projects using KDocTools on windows.

If ${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR} contained /../ elements
file(RELATIVE_PATH) would interpret these as valid directory names and
therefore return a relative path which has too many /../

REVIEW: 115744


Diffs (updated)
-----

  src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa 

Diff: https://git.reviewboard.kde.org/r/115744/diff/


Testing
-------

kservice didn't compile before this change, now it does (win32), doesn't affect other platforms


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/85057401/attachment.html>


More information about the Kde-frameworks-devel mailing list