Review Request 115744: The WIN32 part of this if statement doesn't seem to work -> drop it

[Alex Merry]

> On Feb. 19, 2014, 2:52 p.m., Alex Merry wrote:
> > src/CMakeLists.txt, lines 63-67
> > <https://git.reviewboard.kde.org/r/115744/diff/1/?file=243985#file243985line63>
> >
> >     This warning no longer applies, right?  In that, since we no longer have a monolithic kdelibs, we can just use relative paths in the xsl files.
> 
> Luigi Toscano wrote:
>     I'm not sure it does not apply: the files are not installed either while building kdoctools alone, but I could have mistaken that part. As I said, it was changed by the kde-windows team as it caused issues with emerge, and I can't really say if it's still the case or not.

Oh, true, kdoctools does some docbook building of its own.  I hadn't spotted that.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/#review50247
-----------------------------------------------------------


On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115744/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 12:29 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> The WIN32 part of this if statement doesn't seem to work -> drop it
> 
> The frameworks using KDocTools fail otherwise complaining about invalid
> paths (Win32 build)
> 
> Without this patch I get the following error:
> 
> file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning:
> failed to load external entity
> "file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd"
> 
> The path there is actually correct and should work. However, it seems that
> XSLT does not accept paths starting with a / on windows. Using / is fine
> and evaluates to the root directory of the current drive.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa 
> 
> Diff: https://git.reviewboard.kde.org/r/115744/diff/
> 
> 
> Testing
> -------
> 
> kservice didn't compile before this change, now it does (win32), doesn't affect other platforms
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/b14c0f5f/attachment.html>