Review Request 115742: KParts: Allow compilation on windows

[Alexander Richardson]

> On Feb. 19, 2014, 3:44 p.m., Alex Merry wrote:
> > src/readwritepart.cpp, lines 246-249
> > <https://git.reviewboard.kde.org/r/115742/diff/1/?file=243981#file243981line246>
> >
> >     http://msdn.microsoft.com/en-us/library/windows/desktop/aa363860%28v=vs.85%29.aspx
> >     
> >     So I think the windows version should be
> >     if (CreateHardLink(QFile::encodeName(uploadFile).constData(), QFile::encodeName(d->m_file).constData(), NULL) != 0) {
> >     
> >     You can use partviewer in tests/ to test it.

I saw that functions, but I thought maybe the same restrictions apply to it as with CreateSymbolicLink: only possible with Admin right.
Will check this today and update the review request if it works.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115742/#review50246
-----------------------------------------------------------


On Feb. 14, 2014, 12:59 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115742/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 12:59 a.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> Allow compilation on windows
> 
> 
> Diffs
> -----
> 
>   src/browserextension.h 3ccafcbf0f6628cf7b07ce0436036bb972f95107 
>   src/readwritepart.cpp 693cb76e05d975066ff93e69da27cc25d9dfe35d 
> 
> Diff: https://git.reviewboard.kde.org/r/115742/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/f4d86d16/attachment.html>