Review Request 115742: KParts: Allow compilation on windows

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115742/#review50246
-----------------------------------------------------------



src/readwritepart.cpp
<https://git.reviewboard.kde.org/r/115742/#comment35371>

    http://msdn.microsoft.com/en-us/library/windows/desktop/aa363860%28v=vs.85%29.aspx
    
    So I think the windows version should be
    if (CreateHardLink(QFile::encodeName(uploadFile).constData(), QFile::encodeName(d->m_file).constData(), NULL) != 0) {
    
    You can use partviewer in tests/ to test it.


- Alex Merry


On Feb. 13, 2014, 11:59 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115742/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 11:59 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> Allow compilation on windows
> 
> 
> Diffs
> -----
> 
>   src/browserextension.h 3ccafcbf0f6628cf7b07ce0436036bb972f95107 
>   src/readwritepart.cpp 693cb76e05d975066ff93e69da27cc25d9dfe35d 
> 
> Diff: https://git.reviewboard.kde.org/r/115742/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/7a78ed73/attachment.html>