Review Request 115872: Fix <filename> KUIT markup on windows

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115872/#review50261
-----------------------------------------------------------

Ship it!


Your "testing" statement is a lie: the autotest changed on all platforms.  However, it still passes on Linux.

- Alex Merry


On Feb. 18, 2014, 7:52 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115872/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 7:52 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Fix <filename> KUIT markup on windows
> 
> It breaks when there are nested tags within <filename>...</filename> since
> QDir::toNativeSeparators simply replaces / with \ and then any nested XML
> tags have an invalid closing tag. It also breaks with tags such as <br/>
> in the file name for the same reason.
> 
> 
> Diffs
> -----
> 
>   autotests/klocalizedstringtest.cpp f849ec37ac1e3968a507aa252727076a5d054d0f 
>   src/kuitmarkup.cpp 97a8b21bd1400f3e2b06c65aa43a7fb8056c4515 
> 
> Diff: https://git.reviewboard.kde.org/r/115872/diff/
> 
> 
> Testing
> -------
> 
> KLocalizedStringTest passes on Windows. All changes inside #ifdef Q_OS_WIN, so no change for Linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140219/1d173fc7/attachment.html>