Review Request 115872: Fix <filename> KUIT markup on windows
Alexander Richardson
arichardson.kde at googlemail.com
Tue Feb 18 19:52:52 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115872/
-----------------------------------------------------------
Review request for KDE Frameworks and Chusslove Illich.
Repository: ki18n
Description
-------
Fix <filename> KUIT markup on windows
It breaks when there are nested tags within <filename>...</filename> since
QDir::toNativeSeparators simply replaces / with \ and then any nested XML
tags have an invalid closing tag. It also breaks with tags such as <br/>
in the file name for the same reason.
Diffs
-----
autotests/klocalizedstringtest.cpp f849ec37ac1e3968a507aa252727076a5d054d0f
src/kuitmarkup.cpp 97a8b21bd1400f3e2b06c65aa43a7fb8056c4515
Diff: https://git.reviewboard.kde.org/r/115872/diff/
Testing
-------
KLocalizedStringTest passes on Windows. All changes inside #ifdef Q_OS_WIN, so no change for Linux
Thanks,
Alexander Richardson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140218/3d71591a/attachment.html>
More information about the Kde-frameworks-devel
mailing list