Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11
David Faure
faure at kde.org
Mon Feb 17 08:45:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115721/#review50017
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Feb. 17, 2014, 8:15 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115721/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 8:15 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Reduce usage of HAVE_X11 in KRun and make it usable on non-X11
>
> The diversion for some methods by having a KStartupInfoId is removed.
> As KStartupInfoId is not an X11 specific class we can work with normal
> method overloading instead of needing ifdefs.
>
> In addition the code which uses X11 specific functionality is adjusted
> to be only used if we are on platform X11. For other platforms the
> same fallback is used as already present through the ifdef diversion.
>
>
> Diffs
> -----
>
> src/widgets/krun.cpp 7c378f248d4f3f9bf05449918c27179aeca33cbd
> src/widgets/krun_p.h 05d63670c25a5c73fa6f690fdd73834167f9caf8
>
> Diff: https://git.reviewboard.kde.org/r/115721/diff/
>
>
> Testing
> -------
>
> used kruntest on X11 and Wayland - together with setting QT_QPA_PLATFORM env variable we get the expected result.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/60305b0d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list