Review Request 115721: Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115721/
-----------------------------------------------------------

(Updated Feb. 17, 2014, 9:15 a.m.)


Review request for KDE Frameworks.


Changes
-------

merged the methods as suggested and removed the #else path duplication


Repository: kio


Description
-------

Reduce usage of HAVE_X11 in KRun and make it usable on non-X11

The diversion for some methods by having a KStartupInfoId is removed.
As KStartupInfoId is not an X11 specific class we can work with normal
method overloading instead of needing ifdefs.

In addition the code which uses X11 specific functionality is adjusted
to be only used if we are on platform X11. For other platforms the
same fallback is used as already present through the ifdef diversion.


Diffs (updated)
-----

  src/widgets/krun.cpp 7c378f248d4f3f9bf05449918c27179aeca33cbd 
  src/widgets/krun_p.h 05d63670c25a5c73fa6f690fdd73834167f9caf8 

Diff: https://git.reviewboard.kde.org/r/115721/diff/


Testing
-------

used kruntest on X11 and Wayland - together with setting QT_QPA_PLATFORM env variable we get the expected result.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140217/9fd96a36/attachment.html>