Review Request 115741: Fix MSVC of kinit

[Alexander Richardson]

> On Feb. 15, 2014, 9:40 p.m., David Faure wrote:
> > src/kdeinit/kinit_win.cpp, line 354
> > <https://git.reviewboard.kde.org/r/115741/diff/2/?file=243975#file243975line354>
> >
> >     No need for QString(QStringLiteral()), is there?
> >     
> >     Actually, is QStringLiteral really correct?
> >     Is the input unicode?
> >     
> >     On unix I would have used fromLocal8Bit() for something coming from the command line, but I'm still confused about encoding on Windows so I'm not sure about Windows.

QString is required because QStringLiteral is a lambda and not an actual QString object.

Not sure about the encoding, I lack the necessary Windows knowledge.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115741/#review49874
-----------------------------------------------------------


On Feb. 14, 2014, 12:22 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115741/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 12:22 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kinit
> 
> 
> Description
> -------
> 
> - port from KStandardDirs
> - QT_NO_CAST_FROM_ASCII
> - various small MSVC build fixes
> 
> 
> Diffs
> -----
> 
>   src/klauncher/klauncher.h 5f6d79d65c86e423ba83e096f74cf8dec428667a 
>   src/klauncher/klauncher.cpp 1fd909110003ded5f231b013cc07ee58f1757208 
>   src/klauncher/klauncher_main.cpp 266b5d3ef17651f7ef26af5d3f506c9196f91ef3 
>   src/kwrapper/kwrapper_win.cpp 254edc8554b0fdcaf6d4485b258ec22848036c32 
>   src/kdeinit/CMakeLists.txt c4ca354d022bc446dfd7f0e73abbe360b1e9f1ff 
>   src/kdeinit/kinit_win.cpp 707882f356839fd85265abdcf6d96673102e3f64 
> 
> Diff: https://git.reviewboard.kde.org/r/115741/diff/
> 
> 
> Testing
> -------
> 
> compiles, doesn't affect linux build
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/2c6aab8b/attachment.html>