<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115741/">https://git.reviewboard.kde.org/r/115741/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 15th, 2014, 9:40 p.m. CET, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115741/diff/2/?file=243975#file243975line354" style="color: black; font-weight: bold; text-decoration: underline;">src/kdeinit/kinit_win.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">ProcessListEntry *ProcessList::find(const QString &name)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">345</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">ple</span><span class="o">-></span><span class="n">path</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">&&</span> <span class="o">!</span><span class="n">ple</span><span class="o">-></span><span class="n">path</span><span class="p">.</span><span class="n">toLower</span><span class="p">().</span><span class="n">startsWith</span><span class="p">(</span><span class="n"><span class="hl">KStandardDirs</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">installPath</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"kdedir"</span></span><span class="p">).</span><span class="n">toLower</span><span class="p">()))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">353</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">ple</span><span class="o">-></span><span class="n">path</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span class="o">&&</span> <span class="o">!</span><span class="n">ple</span><span class="o">-></span><span class="n">path</span><span class="p">.</span><span class="n">toLower</span><span class="p">().</span><span class="n">startsWith</span><span class="p">(</span><span class="n"><span class="hl">QString</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">QStringLiteral</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">CMAKE_INSTALL_PREFIX</span></span><span class="p"><span class="hl">)</span>).</span><span class="n">toLower</span><span class="p">()))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No need for QString(QStringLiteral()), is there?
Actually, is QStringLiteral really correct?
Is the input unicode?
On unix I would have used fromLocal8Bit() for something coming from the command line, but I'm still confused about encoding on Windows so I'm not sure about Windows.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QString is required because QStringLiteral is a lambda and not an actual QString object.
Not sure about the encoding, I lack the necessary Windows knowledge.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On February 14th, 2014, 12:22 a.m. CET, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2014, 12:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kinit
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- port from KStandardDirs
- QT_NO_CAST_FROM_ASCII
- various small MSVC build fixes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, doesn't affect linux build</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/klauncher/klauncher.h <span style="color: grey">(5f6d79d65c86e423ba83e096f74cf8dec428667a)</span></li>
<li>src/klauncher/klauncher.cpp <span style="color: grey">(1fd909110003ded5f231b013cc07ee58f1757208)</span></li>
<li>src/klauncher/klauncher_main.cpp <span style="color: grey">(266b5d3ef17651f7ef26af5d3f506c9196f91ef3)</span></li>
<li>src/kwrapper/kwrapper_win.cpp <span style="color: grey">(254edc8554b0fdcaf6d4485b258ec22848036c32)</span></li>
<li>src/kdeinit/CMakeLists.txt <span style="color: grey">(c4ca354d022bc446dfd7f0e73abbe360b1e9f1ff)</span></li>
<li>src/kdeinit/kinit_win.cpp <span style="color: grey">(707882f356839fd85265abdcf6d96673102e3f64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115741/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>