Review Request 115715: Remove X11 dependency from kprintutils

[John Layt]

> On Feb. 14, 2014, 1:58 p.m., John Layt wrote:
> > I'd prefer for now that you just replace the HAVE_X11 with "#defined Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect.  No point in compiling the CUPS code if we're never going to use it.  Once Qt feature freeze kicks in I'll have time to review all this code properly and it's likely most of it will be deleted anyway.
> 
> John Layt wrote:
>     Duh, make that "#if defined Q_OS_UNIX && !defined Q_OS_MAC"
> 
> Nicolás Alvarez wrote:
>     Doesn't Mac use CUPS too?

They do, but wrapped in their own native api and dialogs.  Qt uses the native dialogs rather than the Qt dialogs, so we can't add the tabs to them.  It's a long-term goal to figure out how to embed Qt widgets into the Mac and Windows dialogs :-)


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115715/#review49783
-----------------------------------------------------------


On Feb. 15, 2014, 12:37 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115715/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 12:37 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and John Layt.
> 
> 
> Repository: kprintutils
> 
> 
> Description
> -------
> 
> Remove X11 dependency from kprintutils
> 
> The availability of XLib was used to test whether Cups is available.
> Cups has nothing to do with X11, thus the check is wrong.
> 
> The code does not use any platform specific code and has a runtime
> check whether cups is available. Given the comment it should also
> work correct on platforms which do not have Cups (e.g. Windows).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 28342d0c9149d09ab0b9e41c5ed6d41b695130ed 
>   src/CMakeLists.txt 927b02480db47bb74ea4240e582dbb0f6f6aeac2 
>   src/config-kprintutils.h.cmake 89858d17de239cfc7eed1f40a8b828803de3299c 
>   src/kcupsoptionswidget_p.cpp c88e848a41b72590b13d8b38783cd1c7b1d106d1 
>   src/kdeprintdialog.cpp a53e19846d0f45073f1d6827e7b2eaa2bde859a3 
> 
> Diff: https://git.reviewboard.kde.org/r/115715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140215/ba6f352c/attachment.html>