<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115715/">https://git.reviewboard.kde.org/r/115715/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2014, 1:58 p.m. GMT, <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd prefer for now that you just replace the HAVE_X11 with "#defined Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No point in compiling the CUPS code if we're never going to use it. Once Qt feature freeze kicks in I'll have time to review all this code properly and it's likely most of it will be deleted anyway.</pre>
</blockquote>
<p>On February 14th, 2014, 1:59 p.m. GMT, <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Duh, make that "#if defined Q_OS_UNIX && !defined Q_OS_MAC"</pre>
</blockquote>
<p>On February 14th, 2014, 3:18 p.m. GMT, <b>Nicolás Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Doesn't Mac use CUPS too?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They do, but wrapped in their own native api and dialogs. Qt uses the native dialogs rather than the Qt dialogs, so we can't add the tabs to them. It's a long-term goal to figure out how to embed Qt widgets into the Mac and Windows dialogs :-)</pre>
<br />
<p>- John</p>
<br />
<p>On February 15th, 2014, 12:37 p.m. GMT, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, kdewin and John Layt.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 12:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kprintutils
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove X11 dependency from kprintutils
The availability of XLib was used to test whether Cups is available.
Cups has nothing to do with X11, thus the check is wrong.
The code does not use any platform specific code and has a runtime
check whether cups is available. Given the comment it should also
work correct on platforms which do not have Cups (e.g. Windows).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(28342d0c9149d09ab0b9e41c5ed6d41b695130ed)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(927b02480db47bb74ea4240e582dbb0f6f6aeac2)</span></li>
<li>src/config-kprintutils.h.cmake <span style="color: grey">(89858d17de239cfc7eed1f40a8b828803de3299c)</span></li>
<li>src/kcupsoptionswidget_p.cpp <span style="color: grey">(c88e848a41b72590b13d8b38783cd1c7b1d106d1)</span></li>
<li>src/kdeprintdialog.cpp <span style="color: grey">(a53e19846d0f45073f1d6827e7b2eaa2bde859a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115715/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>