Review Request 115725: Switch from yapgvb to Graphviz Python bindings

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115725/#review49782
-----------------------------------------------------------

Ship it!


Looks good, and works fine for me (both with and without graphviz python bindings installed).

- Alex Merry


On Feb. 13, 2014, 2:22 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115725/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 2:22 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Yapgvb turned out to be painful to deploy, and Ben pointed out that Graphviz provides official Python bindings. Those are less Pythonic, but more widespread and it is safe to assume they are maintained. Switching to those bindings also allow us to avoid temporary files, which is a nice bonus.
> 
> I actually made the changes in two patches: one to switch to gv, the other to remove the temp files.
> 
> 
> Diffs
> -----
> 
>   README.md b88dde0 
>   src/kapidox/depdiagram/frameworkdb.py 8cba5e6 
>   src/kapidox/depdiagram/gvutils.py PRE-CREATION 
>   src/kgenframeworksapidox e684320 
> 
> Diff: https://git.reviewboard.kde.org/r/115725/diff/
> 
> 
> Testing
> -------
> 
> - Generated diagrams with depdiagram-prepare and depdiagram-generate
> - Generated docs with kgenframeworksapidox
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140214/9b7878c9/attachment.html>