<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115725/">https://git.reviewboard.kde.org/r/115725/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, and works fine for me (both with and without graphviz python bindings installed).</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On February 13th, 2014, 2:22 p.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2014, 2:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yapgvb turned out to be painful to deploy, and Ben pointed out that Graphviz provides official Python bindings. Those are less Pythonic, but more widespread and it is safe to assume they are maintained. Switching to those bindings also allow us to avoid temporary files, which is a nice bonus.
I actually made the changes in two patches: one to switch to gv, the other to remove the temp files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Generated diagrams with depdiagram-prepare and depdiagram-generate
- Generated docs with kgenframeworksapidox</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README.md <span style="color: grey">(b88dde0)</span></li>
<li>src/kapidox/depdiagram/frameworkdb.py <span style="color: grey">(8cba5e6)</span></li>
<li>src/kapidox/depdiagram/gvutils.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kgenframeworksapidox <span style="color: grey">(e684320)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115725/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>