Review Request 115640: Add kwin-compositing-kcm to workspace setup

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115640/#review49618
-----------------------------------------------------------

Ship it!


Sounds good to me, but if anyone should review it as "arbiter of what's built by default" it should probably be dfaure, at least until I get the needed time to bootstrap KF5 here myself. ;)

I personally would rearrange some of the modules to use module-sets but I can handle that later.

In the interim I'd suggest making sure that the kde-build-metadata repository has the right branch names for the modules (stored in the logical-module-structure file) but I might audit that myself later as well. In short if build.kde.org is happy with the KF5 modules kde-build-metadata is probably correct.

- Michael Pyne


On Feb. 11, 2014, 7:23 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115640/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 7:23 a.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> We should get this module into the hands of the users :-)
> 
> 
> Diffs
> -----
> 
>   kf5-workspace-build-include ca9ba0c 
> 
> Diff: https://git.reviewboard.kde.org/r/115640/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140212/97477f5f/attachment-0001.html>