<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115640/">https://git.reviewboard.kde.org/r/115640/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sounds good to me, but if anyone should review it as "arbiter of what's built by default" it should probably be dfaure, at least until I get the needed time to bootstrap KF5 here myself. ;)
I personally would rearrange some of the modules to use module-sets but I can handle that later.
In the interim I'd suggest making sure that the kde-build-metadata repository has the right branch names for the modules (stored in the logical-module-structure file) but I might audit that myself later as well. In short if build.kde.org is happy with the KF5 modules kde-build-metadata is probably correct.</pre>
<br />
<p>- Michael Pyne</p>
<br />
<p>On February 11th, 2014, 7:23 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Michael Pyne.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2014, 7:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We should get this module into the hands of the users :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kf5-workspace-build-include <span style="color: grey">(ca9ba0c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115640/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>