Review Request 115613: Drop platform name from default user agent string

[Ben Cooksley]

On Mon, Feb 10, 2014 at 10:21 PM, David Faure <faure at kde.org> wrote:

> On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/115613/
> > -----------------------------------------------------------
> >
> > (Updated Feb. 10, 2014, 9:15 a.m.)
> >
> >
> > Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
> >
> >
> > Changes
> > -------
> >
> > Adding more people for review. IMHO Dawit has final say on what the UA
> > string should look like.
>
> Reviewboard is weird. I added that comment, but the mail sent by
> reviewboard
> doesn't show that anywhere. It makes it look like Martin made that change.
>

Looks like Reviewboard doesn't track the person who makes changes to the
metadata - so it assumes the author of the Review Request made it.
Normally, this would be a valid assumption as only they have the permission
to do so, unless someone has admin access (which you do).

Guess you might want to file an issue with upstream.

Thanks,
Ben


> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
> ---------- Forwarded message ----------
> From: Martin Gräßlin <mgraesslin at kde.org>
> To: Dawit Alemayehu <adawit at kde.org>, Bernhard Beschow <
> bbeschow at cs.tu-berlin.de>
> Cc: KDE Frameworks <kde-frameworks-devel at kde.org>
> Date: Mon, 10 Feb 2014 09:15:23 +0000
> Subject: Re: Review Request 115613: Drop platform name from default user
> agent string
>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115613/
>   Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
> By Martin Gräßlin.
>
> *Updated Feb. 10, 2014, 9:15 a.m.*
> Changes
>
> Adding more people for review. IMHO Dawit has final say on what the UA string should look like.
>
>   *Repository: * kio
> Description
>
> Drop platform name from default user agent string
>
> The platform name (e.g. X11) was currently broken on compile time.
> On Linux it returned unknown and on all other platforms the same
> name as already included in the OS name.
>
> We cannot really determine the platform name as this is a core
> application and the Qt's platform name is only available in a GUI
> application. Compile time is no solution as we cannot know whether
> the binary is executed on X11, Wayland, Android or whatever.
>
>   Diffs
>
>    - src/core/kprotocolmanager.cpp
>    (f81b6797887eebd868c36b98e867eb055b05a1e2)
>
> View Diff <https://git.reviewboard.kde.org/r/115613/diff/>
>
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/e00e0d1e/attachment.html>