<div dir="ltr">On Mon, Feb 10, 2014 at 10:21 PM, David Faure <span dir="ltr"><<a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote:<br>
> -----------------------------------------------------------<br>
<div class="">> This is an automatically generated e-mail. To reply, visit:<br>
> <a href="https://git.reviewboard.kde.org/r/115613/" target="_blank">https://git.reviewboard.kde.org/r/115613/</a><br>
</div>> -----------------------------------------------------------<br>
><br>
> (Updated Feb. 10, 2014, 9:15 a.m.)<br>
<div class="">><br>
><br>
> Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.<br>
><br>
><br>
</div>> Changes<br>
> -------<br>
<div class="">><br>
> Adding more people for review. IMHO Dawit has final say on what the UA<br>
> string should look like.<br>
<br>
</div>Reviewboard is weird. I added that comment, but the mail sent by reviewboard<br>
doesn't show that anywhere. It makes it look like Martin made that change.<br></blockquote><div><br></div><div style>Looks like Reviewboard doesn't track the person who makes changes to the metadata - so it assumes the author of the Review Request made it. Normally, this would be a valid assumption as only they have the permission to do so, unless someone has admin access (which you do).</div>
<div style><br></div><div style>Guess you might want to file an issue with upstream.</div><div style><br></div><div style>Thanks,</div><div style>Ben</div><div style><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
--<br>
David Faure, <a href="mailto:faure@kde.org">faure@kde.org</a>, <a href="http://www.davidfaure.fr" target="_blank">http://www.davidfaure.fr</a><br>
Working on KDE, in particular KDE Frameworks 5<br>
</font></span><br><br>---------- Forwarded message ----------<br>From: Martin Gräßlin <<a href="mailto:mgraesslin@kde.org">mgraesslin@kde.org</a>><br>To: Dawit Alemayehu <<a href="mailto:adawit@kde.org">adawit@kde.org</a>>, Bernhard Beschow <<a href="mailto:bbeschow@cs.tu-berlin.de">bbeschow@cs.tu-berlin.de</a>><br>
Cc: KDE Frameworks <<a href="mailto:kde-frameworks-devel@kde.org">kde-frameworks-devel@kde.org</a>><br>Date: Mon, 10 Feb 2014 09:15:23 +0000<br>Subject: Re: Review Request 115613: Drop platform name from default user agent string<br>
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115613/" target="_blank">https://git.reviewboard.kde.org/r/115613/</a>
</td>
</tr>
</tbody></table>
<br>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td>
<div>Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.</div>
<div>By Martin Gräßlin.</div>
<p style="color:grey"><i>Updated Feb. 10, 2014, 9:15 a.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Adding more people for review. IMHO Dawit has final say on what the UA string should look like.</pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kio
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Drop platform name from default user agent string
The platform name (e.g. X11) was currently broken on compile time.
On Linux it returned unknown and on all other platforms the same
name as already included in the OS name.
We cannot really determine the platform name as this is a core
application and the Qt's platform name is only available in a GUI
application. Compile time is no solution as we cannot know whether
the binary is executed on X11, Wayland, Android or whatever.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/core/kprotocolmanager.cpp <span style="color:grey">(f81b6797887eebd868c36b98e867eb055b05a1e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115613/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a><br>
<br>_______________________________________________<br>
Kde-frameworks-devel mailing list<br>
<a href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a><br>
<br></blockquote></div><br></div></div>