Review Request 115602: Rename kactivitymanagerd
Ivan Čukić
ivan.cukic at kde.org
Sun Feb 9 19:40:10 UTC 2014
> On Feb. 9, 2014, 7:12 p.m., Ivan Čukić wrote:
> > This is not something I'd give a green light for.
> >
> > ActivityManager/KF5 is a drop-in replacement for the current one. They should *not* be installed side-by-side.
> >
> >
>
> Michael Palimaka wrote:
> kactivitymanagerd might be drop in, but the rest of the framework is not. Any consumers that are not ported to KF5 will need to be dropped by packagers if it's not coinstallable.
The library is co-installable. And the old clients will continue working fine.
I don't want someone starting a libkactivities/kf5 client with a kactivitymanagerd/kf4
I would accept porting the KACTIVITIES_LIBRARY_ONLY build option from the kf5 branch to kf4 version.
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115602/#review49377
-----------------------------------------------------------
On Feb. 9, 2014, 6:45 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115602/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2014, 6:45 p.m.)
>
>
> Review request for KDE Frameworks and Ivan Čukić.
>
>
> Repository: kactivities
>
>
> Description
> -------
>
> ...so it can co-exists with kactivities4 in the same prefix
>
>
> Diffs
> -----
>
> src/lib/core/manager_p.cpp 57f60be
> src/service/CMakeLists.txt 348f8a3
> src/service/files/kactivitymanagerd.desktop ce68a49
> tests/core/Process.cpp b6279d0
>
> Diff: https://git.reviewboard.kde.org/r/115602/diff/
>
>
> Testing
> -------
>
> Both Plasma1 and Next ran fine with this patch and withouth kactivitymanagerd(4) installed. Haven't tested the case when they are both installed.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140209/2282193e/attachment.html>
More information about the Kde-frameworks-devel
mailing list