<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115602/">https://git.reviewboard.kde.org/r/115602/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 9th, 2014, 7:12 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not something I'd give a green light for.
ActivityManager/KF5 is a drop-in replacement for the current one. They should *not* be installed side-by-side.
</pre>
</blockquote>
<p>On February 9th, 2014, 7:31 p.m. UTC, <b>Michael Palimaka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kactivitymanagerd might be drop in, but the rest of the framework is not. Any consumers that are not ported to KF5 will need to be dropped by packagers if it's not coinstallable.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The library is co-installable. And the old clients will continue working fine.
I don't want someone starting a libkactivities/kf5 client with a kactivitymanagerd/kf4
I would accept porting the KACTIVITIES_LIBRARY_ONLY build option from the kf5 branch to kf4 version.</pre>
<br />
<p>- Ivan</p>
<br />
<p>On February 9th, 2014, 6:45 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Ivan Čukić.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2014, 6:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kactivities
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">...so it can co-exists with kactivities4 in the same prefix</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Both Plasma1 and Next ran fine with this patch and withouth kactivitymanagerd(4) installed. Haven't tested the case when they are both installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/core/manager_p.cpp <span style="color: grey">(57f60be)</span></li>
<li>src/service/CMakeLists.txt <span style="color: grey">(348f8a3)</span></li>
<li>src/service/files/kactivitymanagerd.desktop <span style="color: grey">(ce68a49)</span></li>
<li>tests/core/Process.cpp <span style="color: grey">(b6279d0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115602/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>