Review Request 115424: Improve kparts dependencies

Michael Palimaka kensington at gentoo.org
Sat Feb 8 17:32:32 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/
-----------------------------------------------------------

(Updated Feb. 8, 2014, 5:32 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Only build tests if BUILD_TESTING is enabled.


Repository: kparts


Description
-------

- QtNetwork is not used
- QtTest is only required for tests
- Remove transitive dependencies


Diffs (updated)
-----

  CMakeLists.txt 8d7a76250a3977120f014eb735a2ef66ca5d59ea 
  autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9 
  tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810 

Diff: https://git.reviewboard.kde.org/r/115424/diff/


Testing
-------

Inspection of source. Builds. Tests pass.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140208/58a07523/attachment.html>


More information about the Kde-frameworks-devel mailing list