Review Request 115424: Improve kparts dependencies

Michael Palimaka kensington at gentoo.org
Sun Feb 2 15:09:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115424/
-----------------------------------------------------------

(Updated Feb. 2, 2014, 3:09 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Don't try to build tests if QtTest is not found.


Repository: kparts


Description
-------

- QtNetwork is not used
- QtTest is only required for tests
- Remove transitive dependencies


Diffs (updated)
-----

  CMakeLists.txt fe6de305d28c2cd073ae1bc5d171f1244d2ed29c 
  autotests/CMakeLists.txt d62107e51d88b0ea46be113b57c318197f3ebaa9 
  tests/CMakeLists.txt d7bca988b59022bb0731a38a5d7e872217541810 

Diff: https://git.reviewboard.kde.org/r/115424/diff/


Testing
-------

Inspection of source. Builds. Tests pass.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140202/4afae0bc/attachment.html>


More information about the Kde-frameworks-devel mailing list