Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115524/#review49241
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 6, 2014, 10:35 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115524/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 10:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> Hide a private method and a private slot of KComboBox behind the d-pointer
> 
> Also:
> --Change lineEdit() for isEditable() for checking whether the kcombobox is editable.
> 
> 
> Diffs
> -----
> 
>   src/kcombobox.h e59d72b 
>   src/kcombobox.cpp 2cfe6e7 
> 
> Diff: https://git.reviewboard.kde.org/r/115524/diff/
> 
> 
> Testing
> -------
> 
> It builds. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140208/c39c31fb/attachment.html>