Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

David Gil Oliva davidgiloliva at gmail.com
Thu Feb 6 22:35:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115524/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 10:35 p.m.)


Review request for KDE Frameworks.


Changes
-------

Uncomment line.


Repository: kcompletion


Description
-------

Hide a private method and a private slot of KComboBox behind the d-pointer

Also:
--Change lineEdit() for isEditable() for checking whether the kcombobox is editable.


Diffs (updated)
-----

  src/kcombobox.h e59d72b 
  src/kcombobox.cpp 2cfe6e7 

Diff: https://git.reviewboard.kde.org/r/115524/diff/


Testing
-------

It builds. Tests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140206/87897961/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list