Review Request 115502: Fix math function checks

Alex Merry kde at randomguy3.me.uk
Thu Feb 6 12:05:33 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115502/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 12:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.


Repository: kjs


Description
-------

Fix math function checks

Between things being in the std:: namespace and <math.h> and <cmath>
interfering with each other (at least for glibc), the configure checks
for math functions do not actually perform the checks they claim to.

This tests that the functions (in whatever form) can reasonably be
called from C++ code that includes both <math.h> and <cmath>.


Diffs
-----

  src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
  src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
  src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 

Diff: https://git.reviewboard.kde.org/r/115502/diff/


Testing
-------

Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux).  The configure checks report the results you would expect (providing you are aware that cmath undefs signbit).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140206/f0b7525c/attachment.html>


More information about the Kde-frameworks-devel mailing list