Review Request 115504: Only perform tests for plugins that are built

Alex Merry kde at randomguy3.me.uk
Wed Feb 5 17:41:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115504/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kimageformats


Description
-------

Only perform tests for plugins that are built

This both excludes the autotests and tests subdirs if the user sets
BUILD_TESTING off, and makes sure we do not run tests for formats that
were not built due to dependencies not being found.


Diffs
-----

  CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 
  autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a 
  src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 

Diff: https://git.reviewboard.kde.org/r/115504/diff/


Testing
-------

Builds and tests pass.  Builds with BUILD_TESTING off (and tests are not build, and make test does nothing).  Commented out the optional find_package calls; still built and tests still passed.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/a7923185/attachment.html>


More information about the Kde-frameworks-devel mailing list