Review Request 115493: Make CMakeLists.txt respect DESTDIR

[Alex Merry]

> On Feb. 5, 2014, 3:31 p.m., Aurélien Gâteau wrote:
> > CMakeLists.txt, line 13
> > <https://git.reviewboard.kde.org/r/115493/diff/1/?file=241990#file241990line13>
> >
> >     I think this can be simplified to:
> >     
> >         if (\$ENV{DESTDIR})

No, it can't.  Tried that, it didn't work.  Try creating the script
=== testenv.cmake ===
message(STATUS "\$ENV{DESTDIR} = $ENV{DESTDIR}")
if ($ENV{DESTDIR})
    message(STATUS "\$ENV{DESTDIR} evaluates to TRUE")
else()
    message(STATUS "\$ENV{DESTDIR} evaluates to FALSE")
endif()
if (ENV{DESTDIR})
    message(STATUS "ENV{DESTDIR} evaluates to TRUE")
else()
    message(STATUS "ENV{DESTDIR} evaluates to FALSE")
endif()
=== testenv.cmake ===
and running
cmake -P testenv.cmake
and
DESTDIR=foo cmake -P testenv.cmake

This is possibly a cmake bug.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115493/#review49034
-----------------------------------------------------------


On Feb. 5, 2014, 11:50 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115493/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 11:50 a.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Make CMakeLists.txt respect DESTDIR
> 
> This should make Jenkins happy.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c8396df5c3dd98e41973a2d38ed368d2f889d085 
> 
> Diff: https://git.reviewboard.kde.org/r/115493/diff/
> 
> 
> Testing
> -------
> 
> `make install` and `make install DESTDIR=/tmp/kapidox` both appear to work as expected.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/9332dc81/attachment-0001.html>