Review Request 115493: Make CMakeLists.txt respect DESTDIR

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115493/#review49034
-----------------------------------------------------------


Looks good, just an inline nitpick. I would also suggest adding a comment explaining why _root_arg must be defined at install time (took me a while to understand $ENV{DESTDIR} is not set at configure or build time). Feel free to ship then.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/115493/#comment34634>

    I think this can be simplified to:
    
        if (\$ENV{DESTDIR})


- Aurélien Gâteau


On Feb. 5, 2014, 12:50 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115493/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 12:50 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Make CMakeLists.txt respect DESTDIR
> 
> This should make Jenkins happy.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c8396df5c3dd98e41973a2d38ed368d2f889d085 
> 
> Diff: https://git.reviewboard.kde.org/r/115493/diff/
> 
> 
> Testing
> -------
> 
> `make install` and `make install DESTDIR=/tmp/kapidox` both appear to work as expected.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/1625db44/attachment.html>