Review Request 115355: Import the WebP image I/O code from kde-runtime
Alex Merry
kde at randomguy3.me.uk
Wed Feb 5 15:31:24 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115355/
-----------------------------------------------------------
(Updated Feb. 5, 2014, 3:31 p.m.)
Review request for KDE Frameworks and Alex Merry.
Changes
-------
Add autotests and merge in https://git.reviewboard.kde.org/r/115492
Repository: kimageformats
Description (updated)
-------
Also includes the commit "Add magic detection for WebP files to mimetype description", from https://git.reviewboard.kde.org/r/115492
Import the WebP image I/O code from kde-runtime
The plugin export mechanism has been patched up (including the addition
of the JSON file), and the FindWebP.cmake file is new.
Writing is currently disabled, as it produces broken images.
Autotests are generated using the cwebp and dwebp utilities distributed
with the libwebp reference library.
Diffs (updated)
-----
autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a
autotests/read/webp/bw-cwebp-lossless.png PRE-CREATION
autotests/read/webp/bw-cwebp-lossless.webp PRE-CREATION
autotests/read/webp/bw-cwebp.png PRE-CREATION
autotests/read/webp/bw-cwebp.webp PRE-CREATION
autotests/read/webp/rgb-cwebp-lossless.png PRE-CREATION
autotests/read/webp/rgb-cwebp-lossless.webp PRE-CREATION
autotests/read/webp/rgb-cwebp.png PRE-CREATION
autotests/read/webp/rgb-cwebp.webp PRE-CREATION
cmake/FindWebP.cmake PRE-CREATION
src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8
src/imageformats/webp.cpp PRE-CREATION
src/imageformats/webp.desktop PRE-CREATION
src/imageformats/webp.h PRE-CREATION
src/imageformats/webp.json PRE-CREATION
src/imageformats/webp.xml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115355/diff/
Testing
-------
Compiles; installs; the imageconverter test utility manages to convert from webp fine (PNG results checked in Gwenview from KDE4).
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/e37b62f5/attachment.html>
More information about the Kde-frameworks-devel
mailing list