<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115355/">https://git.reviewboard.kde.org/r/115355/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated Feb. 5, 2014, 3:31 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add autotests and merge in https://git.reviewboard.kde.org/r/115492</pre>
  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  (updated)</h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also includes the commit "Add magic detection for WebP files to mimetype description", from https://git.reviewboard.kde.org/r/115492



Import the WebP image I/O code from kde-runtime

The plugin export mechanism has been patched up (including the addition
of the JSON file), and the FindWebP.cmake file is new.

Writing is currently disabled, as it produces broken images.

Autotests are generated using the cwebp and dwebp utilities distributed
with the libwebp reference library.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles; installs; the imageconverter test utility manages to convert from webp fine (PNG results checked in Gwenview from KDE4).</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/CMakeLists.txt <span style="color: grey">(0192636c3617bf37264a3895e61ecd837e228c4a)</span></li>

 <li>autotests/read/webp/bw-cwebp-lossless.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/bw-cwebp-lossless.webp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/bw-cwebp.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/bw-cwebp.webp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/rgb-cwebp-lossless.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/rgb-cwebp-lossless.webp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/rgb-cwebp.png <span style="color: grey">(PRE-CREATION)</span></li>

 <li>autotests/read/webp/rgb-cwebp.webp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/FindWebP.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/CMakeLists.txt <span style="color: grey">(242753e0b2c493bbf1da9654967494415e8249d8)</span></li>

 <li>src/imageformats/webp.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/webp.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/webp.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/webp.json <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/imageformats/webp.xml <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115355/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>