Review Request 115433: Fix compilation where struct addrinfo is already defined

[Valentin Rusu]

> On Feb. 2, 2014, 12:40 p.m., Alex Merry wrote:
> > Have you updated extra-cmake-modules recently?  I pushed a fix for this issue a few days ago.  Specifically, the issue was _GNU_SOURCE etc being defined when building, but not when running configure tests.

Yes, I did a full KF5 rebuild. But I didn't force --refresh-build, though. I'll retry a full rebuild now.


> On Feb. 2, 2014, 12:40 p.m., Alex Merry wrote:
> > src/kdecore/netsupp.h, line 164
> > <https://git.reviewboard.kde.org/r/115433/diff/1/?file=241345#file241345line164>
> >
> >     Definitely wrong.  Since HAVE_STRUCT_ADDRINFO is *always* defined (either to 0 or 1), you've just made sure this always evalutates to false...

OK, you're right. I'll stop trying to fix things at midnight after tiering weeks :o)


- Valentin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115433/#review48766
-----------------------------------------------------------


On Feb. 2, 2014, 10:38 a.m., Valentin Rusu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115433/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 10:38 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> -------
> 
> kde4support framework stopped building on my system (ArchLinux), after updating I suppose.
> Here is the error I had when building:
> 
> In file included from /home/kde5/src/frameworks/kde4support/src/kdecore/k3reverseresolver.cpp:48:0:
> /home/kde5/src/frameworks/kde4support/src/kdecore/netsupp.h:168:8: error: redefinition of ‘struct addrinfo’
>  struct addrinfo {
>         ^
> In file included from /home/kde5/src/frameworks/kde4support/src/kdecore/k3reverseresolver.cpp:32:0:
> /usr/include/netdb.h:567:8: error: previous definition of ‘struct addrinfo’
>  struct addrinfo
>         ^
> src/CMakeFiles/KF5KDE4Support.dir/build.make:606: recipe for target 'src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3reverseresolver.cpp.o' failed
> make[2]: *** [src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3reverseresolver.cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> 
> 
> Diffs
> -----
> 
>   src/kdecore/netsupp.h ef3c3e8263683e8e707e8ee5b0204dad1fb37ecc 
> 
> Diff: https://git.reviewboard.kde.org/r/115433/diff/
> 
> 
> Testing
> -------
> 
> kde4support now builds.
> 
> 
> Thanks,
> 
> Valentin Rusu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140202/9b9df482/attachment.html>