<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115433/">https://git.reviewboard.kde.org/r/115433/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 2nd, 2014, 12:40 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you updated extra-cmake-modules recently? I pushed a fix for this issue a few days ago. Specifically, the issue was _GNU_SOURCE etc being defined when building, but not when running configure tests.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I did a full KF5 rebuild. But I didn't force --refresh-build, though. I'll retry a full rebuild now.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 2nd, 2014, 12:40 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115433/diff/1/?file=241345#file241345line164" style="color: black; font-weight: bold; text-decoration: underline;">src/kdecore/netsupp.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">extern KDE4SUPPORT_DEPRECATED_EXPORT int kde_getaddrinfo(const char *name, const char *service,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"># if !HAVE_STRUCT_ADDRINFO</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"># if !<span class="hl">defined(</span>HAVE_STRUCT_ADDRINFO<span class="hl">)</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Definitely wrong. Since HAVE_STRUCT_ADDRINFO is *always* defined (either to 0 or 1), you've just made sure this always evalutates to false...</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, you're right. I'll stop trying to fix things at midnight after tiering weeks :o)</pre>
<br />
<p>- Valentin</p>
<br />
<p>On February 2nd, 2014, 10:38 a.m. UTC, Valentin Rusu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Valentin Rusu.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2014, 10:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde4support framework stopped building on my system (ArchLinux), after updating I suppose.
Here is the error I had when building:
In file included from /home/kde5/src/frameworks/kde4support/src/kdecore/k3reverseresolver.cpp:48:0:
/home/kde5/src/frameworks/kde4support/src/kdecore/netsupp.h:168:8: error: redefinition of ‘struct addrinfo’
struct addrinfo {
^
In file included from /home/kde5/src/frameworks/kde4support/src/kdecore/k3reverseresolver.cpp:32:0:
/usr/include/netdb.h:567:8: error: previous definition of ‘struct addrinfo’
struct addrinfo
^
src/CMakeFiles/KF5KDE4Support.dir/build.make:606: recipe for target 'src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3reverseresolver.cpp.o' failed
make[2]: *** [src/CMakeFiles/KF5KDE4Support.dir/kdecore/k3reverseresolver.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kde4support now builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdecore/netsupp.h <span style="color: grey">(ef3c3e8263683e8e707e8ee5b0204dad1fb37ecc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115433/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>